Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EY-2660 Proxy mot tilbakekreving, samt litt rydding #101

Merged
merged 7 commits into from
Sep 27, 2023

Conversation

henrikg
Copy link
Contributor

@henrikg henrikg commented Sep 22, 2023

Legger på et endepunkt for å gjøre kall mot soap-tjeneste for tilbakekreving da denne tjenesten ligger on-prem og ikke er eksponert. Dette er ikke en ren proxy siden vi må gjøre oppslag mot STS for å hente token som legges som en del av soap-payload videre.

Også ryddet litt opp i pakkestruktur og navn.

@henrikg henrikg requested a review from a team as a code owner September 22, 2023 14:11
@henrikg henrikg force-pushed the ey-2660-proxy-mot-tilbakekreving branch from 435f570 to 057f433 Compare September 22, 2023 14:17
@henrikg
Copy link
Contributor Author

henrikg commented Sep 22, 2023

Tror dette vil fungere ok, alternativet er å legge hele etterlatte-tilbakekreving on-prem. Usikker på om det vil medføre andre problemer evnt

Copy link
Contributor

@Bjodn Bjodn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ser bra ut 👍 Soap er noe herk 😆

@@ -30,11 +32,10 @@ fun main(args: Array<String>): Unit = io.ktor.server.netty.EngineMain.main(args)
fun Application.module() {
val config = runBlocking { environment.config.load() }
val stsClient = StsClient(config.sts)
Copy link
Contributor

@Bjodn Bjodn Sep 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename variabel og klasse til stsRestClient?

- name: INSTITUSJONSOPPHOLD_URL
value: https://inst2.intern.nav.no
- name: INSTITUSJONSOPPHOLD_AZURE_SCOPE
value: api://prod-fss.team-rocket.inst2/.default
- name: TILBAKEKREVING_URL
value: https://cics.adeo.no/oppdrag/K231CW80
prometheus:
enabled: true
path: /internal/prometheus
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ingen inbound-regel i produksjon ennå da etterlatte-tilbakekreving ikke er deployet til prod

Copy link
Contributor

@Bjodn Bjodn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@henrikg henrikg force-pushed the ey-2660-proxy-mot-tilbakekreving branch from a8b9c09 to 035fae0 Compare September 26, 2023 11:35
@henrikg henrikg force-pushed the ey-2660-proxy-mot-tilbakekreving branch from cc971b1 to 9120339 Compare September 26, 2023 21:04
@henrikg henrikg merged commit 30bb8d8 into main Sep 27, 2023
@henrikg henrikg deleted the ey-2660-proxy-mot-tilbakekreving branch September 27, 2023 07:24
madsop-nav pushed a commit that referenced this pull request Sep 5, 2024
Bumps the alt group with 1 update: [org.junit.jupiter:junit-jupiter-api](https://github.com/junit-team/junit5).


Updates `org.junit.jupiter:junit-jupiter-api` from 5.10.3 to 5.11.0
- [Release notes](https://github.com/junit-team/junit5/releases)
- [Commits](junit-team/junit5@r5.10.3...r5.11.0)

---
updated-dependencies:
- dependency-name: org.junit.jupiter:junit-jupiter-api
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: alt
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants