Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legger til custom event for history.pushState #265

Merged
merged 4 commits into from
May 6, 2024
Merged

Conversation

anders-nom
Copy link
Contributor

No description provided.

@anders-nom anders-nom requested a review from a team as a code owner May 3, 2024 11:52
@anders-nom anders-nom linked an issue May 3, 2024 that may be closed by this pull request
@@ -42,6 +42,8 @@ class OpsMessages extends HTMLElement {
this.messages = opsMessages;
this.render();
});

window.addEventListener("historyPush", () => this.render());
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
window.addEventListener("historyPush", () => this.render());
window.addEventListener("historyPush", this.render);

Copy link

sonarqubecloud bot commented May 3, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Collaborator

@andnorda andnorda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andnorda andnorda merged commit 4b556ea into main May 6, 2024
5 checks passed
@andnorda andnorda deleted the history-push-events branch May 6, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Håndtere navigering i SPA'er
2 participants