Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/upgrade ktlint gradle plugin #1394

Merged
merged 3 commits into from
Apr 20, 2023
Merged

Conversation

sondrele
Copy link
Contributor

  • Gradle plugin for ktlint har blitt oppgradert til siste versjon, samt at siste versjon av ktlint blir satt i configen for alle prosjekter (0.48.2)
  • ktlint-regler kan nå bli definert i .editorconfig i stedet for byggescriptet
  • Har ikke gjort noen endringer i formatteringsreglene, men nyeste versjon har nå trailing commas som standard (samt et par andre preferanser) og dette dro med seg ganske mange endringer
  • Har også testet ut at intellij-pluginen for ktlint fungerer for siste versjon av intellij, og denne ser også ut til å respektere konfigurasjonen i .editorconfig, så virker som at det er mulig å bruke denne i kombinasjon med det vi har definert i gradle: https://plugins.jetbrains.com/plugin/15057-ktlint-unofficial-
  • Evt fungerer det som alltid å kjøre gradle ktlintFormat manuelt fra kommandolinja (eller kjøre via gradle-plugin i intellij) for å formattere filene

@sondrele sondrele requested a review from a team as a code owner April 19, 2023 15:09
sndrem
sndrem previously approved these changes Apr 20, 2023
dependabot bot and others added 3 commits April 20, 2023 09:48
Bumps org.jlleitschuh.gradle.ktlint from 10.3.0 to 11.3.1.

---
updated-dependencies:
- dependency-name: org.jlleitschuh.gradle.ktlint
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@sondrele sondrele force-pushed the chore/upgrade-ktlint-gradle-plugin branch from 4b39c08 to be9b1ed Compare April 20, 2023 07:55
@sondrele sondrele added this pull request to the merge queue Apr 20, 2023
Merged via the queue into main with commit 9d16a4b Apr 20, 2023
@sondrele sondrele deleted the chore/upgrade-ktlint-gradle-plugin branch April 20, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants