Make the modified file distribution handler to be loaded first #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donggyu04
force-pushed
the
feature/move-file-dist-handler-to-controller
branch
from
731e94a to
dbfbc84
Compare
imbyungjun
previously approved these changes
Oct 15, 2020
donggyu04
force-pushed
the
feature/move-file-dist-handler-to-controller
branch
2 times, most recently
from
8ac186f to
2a19fb6
Compare
donggyu04
force-pushed
the
feature/move-file-dist-handler-to-controller
branch
from
2a19fb6 to
d21e1e6
Compare
donggyu04
changed the title
songeunwoo
approved these changes
Oct 15, 2020
imbyungjun
approved these changes
Oct 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We overwrote grinder's
FileDistributionHandlerImplementationto prevent clearing distributed files on the agent side when a new performance test is started.Currently, this file is in the ngrinder-core module, so classloader can not ensure to load the modified class in controller.
As actual code is used in the controller, I move the overwritten file from ngrinder-core to ngrinder-controller.