Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(subchart, zoom): Fix returning domain value #3348

Merged
merged 1 commit into from
Aug 18, 2023
Merged

fix(subchart, zoom): Fix returning domain value #3348

merged 1 commit into from
Aug 18, 2023

Conversation

netil
Copy link
Member

@netil netil commented Aug 18, 2023 •
edited
Loading

Issue

#3347

Details

  • Adjust .subchart()/.zoom() domain return value
  • Update subchart.onbrush callback to be called only by dragging or API call

  • onbrush callback

    • shouldn’t be called at initialization
    • only called when user drags or by API call

  • Zoom/Subchart precision

    • Due to the limitations of floating point precision, scale value may not be exact and it returns approximately values.

fix(subchart, zoom): Fix returning domain value
06ec9b3 
- Adjust .subchart()/.zoom() domain return value
- Update subchart.onbrush callback to be called only by dragging or API call

Ref naver#3347
@netil netil self-assigned this Aug 18, 2023
@coveralls
Copy link

Coverage Status

coverage: 91.504% (+0.01%) from 91.49% when pulling 06ec9b3 on netil:zoomDomain#3347 into 976f04a on naver:master.

@netil netil merged commit 90338ec into naver:master Aug 18, 2023
@netil netil deleted the zoomDomain#3347 branch August 18, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@netil netil

Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@netil @coveralls