Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intent to remove .transform() API #801

Open
netil opened this issue Mar 8, 2019 · 2 comments
Open

Intent to remove .transform() API #801

netil opened this issue Mar 8, 2019 · 2 comments

Comments

@netil
Copy link
Member

netil commented Mar 8, 2019

Description

.transform() facilitate change generated chart type in a easy way.

Background

At the initialization, even though isn't necessary to be generated, some elements are generated.

Ex. if generate 'pie' type, axis elements are generated also.

The primary reason of this behavior comes from the possibility of the transforming type generated to different one. With this assumption, makes harder to optimize and complicating the process in general.

Also there's no practical real usecases on transforming types.

  • Chart is usually used to represent "some data" and it stays as is
  • Transforming looks "fancy", but there's no practical usage functionality
  • Getting rid of the possibility of type changes can reduce the complexity on implementing future changes(features)

Asking for help

This is very early though that I'm trying to implement. Before that, I want hear some feedback.
Please, leave comments on this. Thanks in advance!

@mivdnber
Copy link

mivdnber commented Apr 8, 2019

I'm all for it that means reduced code complexity. Just regenerating the entire chart sounds like it would handle 99% of all use cases.

@netil netil pinned this issue May 20, 2019
@netil
Copy link
Member Author

netil commented Jun 8, 2020

Just released first RC version of v2.

For more details, checkout the changelog:

@netil netil unpinned this issue Jun 9, 2020
netil added a commit that referenced this issue Jul 16, 2020
As of the deprecation of .transform() API, remove all related demos.

Ref #801
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants