Address PR comments

navapbc · Jun 25, 2024 · 0ca92ca · 0ca92ca
1 parent 3bc7c0e
commit 0ca92ca
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 4 deletions.
diff --git a/app-rails/local.env.example b/app-rails/local.env.example
@@ -19,8 +19,12 @@ AWS_ACCESS_KEY_ID=<FILL ME IN>
 AWS_SECRET_ACCESS_KEY=<FILL ME IN>
 AWS_DEFAULT_REGION=<FILL ME IN>
 
+############################
+# File storage
+############################
+
 # Uncomment and fill in an AWS S3 bucket name to use S3 for file storage
-# AWS_BUCKET_NAME=<FILL ME IN>
+# BUCKET_NAME=<FILL ME IN>
 
 ############################
 # Auth

diff --git a/docs/app-rails/technical-foundation.md b/docs/app-rails/technical-foundation.md
@@ -60,9 +60,9 @@ To preview email views in the browser, visit: `/rails/mailers`
 
 To test AWS SES email sending locally:
 
-1. Set the "AWS services" env var in your `.env` file
-1. Set the `SES_EMAIL` env var to a verified sending identity
-1. Restart the server
+1. Set the "AWS services" environment variables in your `.env` file.
+1. Add an `SES_EMAIL` environment variable to a verified sending identity.
+1. Restart the server.
 
 ### 🎭 Authentication
 

diff --git a/template-only-docs/Deployment.md b/template-only-docs/Deployment.md
@@ -41,3 +41,8 @@ While following the [infrastructure template installation instructions](https://
     }
     ```
 1. Follow the infrastructure template instructions to configure [custom domains](https://github.com/navapbc/template-infra/blob/main/docs/infra/set-up-custom-domains.md) and [https support](https://github.com/navapbc/template-infra/blob/main/docs/infra/https-support.md).
+
+## Deploying using another method
+
+- AWS Cognito requires a lot of configuration to work correctly. See the Nava Platform infrastructure template for example configuration.
+- If you are deploying using AWS ECS, but don't want to use the Platform infrastructure template, pass in environment variables and secrets using the ECS task definition. Use the `environment` key for environment variables and the `secrets` key with `valueFrom` for secrets.