Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Docker Compose V2 #88

Merged
merged 2 commits into from
Nov 13, 2023
Merged

Use Docker Compose V2 #88

merged 2 commits into from
Nov 13, 2023

Conversation

michael-wojcik
Copy link
Contributor

@michael-wojcik michael-wojcik commented Jan 19, 2023 •
edited by sawyerh
Loading

Ticket

Resolves #33

Changes

  • Updates all references to docker-compose to docker compose.

@michael-wojcik michael-wojcik mentioned this pull request Jan 19, 2023
Closed
lorenyu
lorenyu approved these changes Jan 19, 2023
View reviewed changes
Copy link
Contributor

@lorenyu lorenyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just had one comment about the documentation.

Also nitpick but could you clean up the placeholder text in the PR description

docs/app/README.md Outdated Show resolved Hide resolved
@chouinar chouinar removed their request for review July 3, 2023 14:32
@sawyerh
Merge branch 'main' of github.com:navapbc/template-application-flask …
dde604a 
…into feature/33-docker-compose-v2

# Conflicts:
#	app/Makefile
#	app/local.env
#	docker-compose.yml
#	docs/app/README.md
@sawyerh sawyerh changed the title 👌 IMPROVE: update to Docker Compose V2 [#33] Use Docker Compose V2 Nov 13, 2023
@sawyerh sawyerh merged commit 0d1f1de into main Nov 13, 2023
@sawyerh sawyerh deleted the feature/33-docker-compose-v2 branch November 13, 2023 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lorenyu lorenyu lorenyu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch to docker compose v2
3 participants
@michael-wojcik @lorenyu @sawyerh