Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Python version in pyproject.toml #226

Merged
merged 3 commits into from
Jun 6, 2024
Merged

Bump Python version in pyproject.toml #226

merged 3 commits into from
Jun 6, 2024

Conversation

KevinJBoyer
Copy link
Contributor

@KevinJBoyer KevinJBoyer commented Jun 6, 2024

Ticket

n/a

Changes

Changes minimum Python version in pyproject.toml to 3.12.
Fixes two minor unrelated typos in documentation.

Context for reviewers

The repo includes a .python-version set to 3.12, so the minimum version Poetry requires of dependencies should match.

Alternatively, we could downgrade the .python-version to 3.10, but that seems unnecessary.

Testing

All existing tests pass.

@KevinJBoyer KevinJBoyer requested a review from chouinar June 6, 2024 18:52
@KevinJBoyer KevinJBoyer marked this pull request as ready for review June 6, 2024 18:52
Copy link
Contributor

@chouinar chouinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@KevinJBoyer KevinJBoyer merged commit cbcc8d8 into main Jun 6, 2024
4 checks passed
@KevinJBoyer KevinJBoyer deleted the kb/doc-fixes branch June 6, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants