Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
n/a
Changes
Context for reviewers
While working on another PR I realized the domain configs are intermingled with service configs. This PR cleans that up. Also removed a variable that we don't need since we can just use the configuration set that's associated with the domain identity.
Testing
Running
![image](https://private-user-images.githubusercontent.com/447859/404447340-0dc36f1a-482f-48df-8598-e738af971fab.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzNzkwOTgsIm5iZiI6MTczOTM3ODc5OCwicGF0aCI6Ii80NDc4NTkvNDA0NDQ3MzQwLTBkYzM2ZjFhLTQ4MmYtNDhkZi04NTk4LWU3MzhhZjk3MWZhYi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjEyJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxMlQxNjQ2MzhaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0xMDA4Mjg0NGZkZTU2MjE2NDIzMTJhOTlkYzgxMzA4ZmNlZmZjZTcwMmE2YjUyMmQ2MzBhOGFkYmY0N2FlYjliJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.OeckYbbB2E3Yg4KNXOfz46UgOu-ZQqx0u4biNjMRv44)
make infra-update-app-service APP_NAME=app ENVIRONMENT=dev
shows no changesAlso tested notifications to make sure it still works
![image](https://private-user-images.githubusercontent.com/447859/404460965-2b05d0fb-189a-4e4f-9f11-70246d26a7f7.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzNzkwOTgsIm5iZiI6MTczOTM3ODc5OCwicGF0aCI6Ii80NDc4NTkvNDA0NDYwOTY1LTJiMDVkMGZiLTE4OWEtNGU0Zi05ZjExLTcwMjQ2ZDI2YTdmNy5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjEyJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxMlQxNjQ2MzhaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1mZGY1MWUyMTc4YzNhODNhOGFlODUxZjA3YTBkYzNjNjcxZmYxODE1MTBjYzYzMzJmYzA1OWMxMTNlODEyYWVkJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.-BDLWpijoSrhguF6TS6SF7WhNHxO-vStY-joIeD9e7w)
Preview environment
♻️ Environment destroyed ♻️