allow additional properties in values root #444
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #287
By allowing additional properties in the root of the schema, anyone can use extra dependencies or pass the same
values.yaml
file to different helm charts. At the same time, we have safety in nautobot's chart specific scopes.Meaning:
This is now allowed:
This will still produce and error and fail:
Because we have
"additionalProperties": false
under specific objects (eg nautobot, ingress).