Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow additional properties in values root #444

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

gertzakis
Copy link
Contributor

Fixes: #287

By allowing additional properties in the root of the schema, anyone can use extra dependencies or pass the same values.yaml file to different helm charts. At the same time, we have safety in nautobot's chart specific scopes.
Meaning:
This is now allowed:

extraKey:
    name: blabla
nautobot:
    image: <nautobot_image>

This will still produce and error and fail:

extraKey:
    name: blabla
nautobot:
    extraKeyNotDefinedInSchema: blabla
ingress:
   extraKeyNotDefinedInSchema: blabla

Because we have "additionalProperties": false under specific objects (eg nautobot, ingress).

@gertzakis gertzakis requested a review from ubajze as a code owner September 19, 2024 09:49
Copy link
Contributor

@ubajze ubajze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gertzakis gertzakis merged commit dcf0358 into nautobot:develop Sep 20, 2024
3 of 4 checks passed
@gertzakis gertzakis deleted the allow-additional-prop branch September 20, 2024 06:32
@gertzakis gertzakis mentioned this pull request Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: Allow additional properties in schema
2 participants