Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connection Pool + Improve JetStream Advisories #134

Merged
merged 5 commits into from
Mar 15, 2023
Merged

Connection Pool + Improve JetStream Advisories #134

merged 5 commits into from
Mar 15, 2023

Conversation

caleblloyd
Copy link
Contributor

  • Adds a connection pool, useful when performing multiple Service Observations from the same User
  • Improves JetStream Advisories to work in the same manner as Service Observations
  • Adds all possible authentication methods for Service Observations and JetStream Advisories

@caleblloyd caleblloyd requested a review from piotrpio March 10, 2023 20:01
piotrpio
piotrpio reviewed Mar 15, 2023
View reviewed changes
piotrpio
piotrpio approved these changes Mar 15, 2023
View reviewed changes
Copy link
Contributor

@piotrpio piotrpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo reported by CI: https://github.com/nats-io/nats-surveyor/pull/134/files#diff-91c837fad61f054ecc8f53f637fcab08e91304c71d2b85aee07f120268a3d8ceR186

Other than that, LGTM

caleblloyd
caleblloyd commented Mar 15, 2023
View reviewed changes
Caleb Lloyd and others added 5 commits March 15, 2023 16:25
connection pool
e18cd3b 
Signed-off-by: Caleb Lloyd <[email protected]>
reverse nil check
87325ef 
Signed-off-by: Caleb Lloyd <[email protected]>
fix linting
1aac7a6 
Signed-off-by: Caleb Lloyd <[email protected]>
pr comments
5ed95e1 
Signed-off-by: Caleb Lloyd <[email protected]>
@caleblloyd
fix spelling
79c99a3
@caleblloyd caleblloyd merged commit 6f0fa99 into main Mar 15, 2023
@caleblloyd caleblloyd deleted the conn-pool branch March 15, 2023 20:33
@caleblloyd caleblloyd mentioned this pull request Mar 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piotrpio piotrpio piotrpio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caleblloyd @piotrpio