Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADDED] Observation listeners #120

Merged
merged 10 commits into from
Jan 27, 2023
Merged

[ADDED] Observation listeners #120

merged 10 commits into from
Jan 27, 2023

Conversation

piotrpio
Copy link
Contributor

@piotrpio piotrpio commented Jan 23, 2023 •
edited
Loading

  • added ManageObservations() exposing methods to add/remove observations on running surveyor
  • added file watcher to enable adding/removing observation files on running surveyor

@piotrpio piotrpio requested a review from caleblloyd January 23, 2023 22:58
@piotrpio piotrpio force-pushed the service-observations branch from f1c05a4 to e8ea7a0 Compare January 23, 2023 23:00
@piotrpio piotrpio marked this pull request as draft January 23, 2023 23:11
@piotrpio piotrpio force-pushed the service-observations branch 3 times, most recently from bec4469 to daf4b24 Compare January 24, 2023 11:06
@piotrpio piotrpio force-pushed the service-observations branch from daf4b24 to 0d98d69 Compare January 24, 2023 11:21
@piotrpio piotrpio force-pushed the service-observations branch from 8a7b405 to 53b82b4 Compare January 24, 2023 11:49
@piotrpio piotrpio force-pushed the service-observations branch from efc1085 to c501f58 Compare January 24, 2023 12:02
@piotrpio piotrpio marked this pull request as ready for review January 24, 2023 12:07
caleblloyd
caleblloyd reviewed Jan 24, 2023
View reviewed changes
@piotrpio piotrpio force-pushed the service-observations branch from a92b548 to 365d3f3 Compare January 25, 2023 13:48
@piotrpio piotrpio force-pushed the service-observations branch from 365d3f3 to 6261fde Compare January 25, 2023 14:02
@piotrpio piotrpio requested a review from caleblloyd January 25, 2023 14:16
caleblloyd
caleblloyd reviewed Jan 26, 2023
View reviewed changes
@piotrpio piotrpio force-pushed the service-observations branch from d79b34d to 06dd5c1 Compare January 27, 2023 13:21
caleblloyd
caleblloyd approved these changes Jan 27, 2023
View reviewed changes
Copy link
Contributor

@caleblloyd caleblloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@piotrpio piotrpio force-pushed the service-observations branch from 06dd5c1 to 2685128 Compare January 27, 2023 13:37
@piotrpio piotrpio merged commit c560fba into main Jan 27, 2023
@piotrpio piotrpio deleted the service-observations branch January 27, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caleblloyd caleblloyd caleblloyd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@piotrpio @caleblloyd