Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle max_closed_clients property #6497

Conversation

ajax-surovskyi-y
Copy link
Contributor

@ajax-surovskyi-y ajax-surovskyi-y commented Feb 11, 2025

Fixes: #6496

Signed-off-by: Yevhen Surovskyi [email protected]

@ajax-surovskyi-y ajax-surovskyi-y requested a review from a team as a code owner February 11, 2025 14:16
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test could be "simplified".

@ajax-surovskyi-y
Copy link
Contributor Author

@kozlovic, I've fixed your comments. re-review please

Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit 4b32d39 into nats-io:main Feb 13, 2025
2 checks passed
neilalexander added a commit that referenced this pull request Feb 17, 2025
Fixes: #6496

Signed-off-by: Yevhen Surovskyi <[email protected]>
neilalexander added a commit that referenced this pull request Feb 18, 2025
Fixes: #6496

Signed-off-by: Yevhen Surovskyi <[email protected]>
neilalexander added a commit that referenced this pull request Feb 18, 2025
Includes the following:

- #6507
- #6497
- #6476
- #6511
- #6513
- #6517
- #6515
- #6519
- #6521

Signed-off-by: Neil Twigg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inability to override MaxClosedClients via configuration file
3 participants