NRG: Lockless Leaderless and HadPreviousLeader
#6438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Neil Twigg <[email protected]>
…hreshold` Signed-off-by: Neil Twigg <[email protected]>
| @@ -4436,7 +4436,11 @@ func (js *jetStream) processClusterCreateConsumer(ca *consumerAssignment, state | |||
| if isConfigUpdate = !reflect.DeepEqual(&cfg, ca.Config); isConfigUpdate { | |||
| // Call into update, ignore consumer exists error here since this means an old deliver subject is bound | |||
| // which can happen on restart etc. | |||
| if err := o.updateConfig(ca.Config); err != nil && err != NewJSConsumerNameExistError() { | |||
| // JS lock needed as this can mutate the consumer assignments and race with updateInactivityThreshold. | |||
| js.mu.Lock() | |||
There was a problem hiding this comment.
These suppose to be part of this PR?
There was a problem hiding this comment.
Something about the changing in the locking caused this race condition to hit far more often, to the point that it was taking several attempts of kicking CI.
I've kept it isolated in a second commit though, as that change won't be relevant for a 2.10.x backport.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes lock contention around JS API requests figuring out if the meta group is leaderless or not by instead tracking that state atomically.
Also fixes a race condition in inactivity thresholds/consumer pause that this seemed to uncover.
Signed-off-by: Neil Twigg [email protected]