Test: expected a fully formed cluster error #6364
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cluster tests would sometimes fail with the following error message:
This was due to a logic error in the tests, where it was assumed that once a meta leader is chosen it will remain the same. That's not always true as the meta leader can still shift around. So, keep fetching the latest leader and check the peers on that.
Previously it would fail by selecting a meta leader, the meta leader would change, and the follower would then be used to request peers on. But because of the following lines in
JetStreamClusterPeers()
:You'd get no peers at all, leading into that error message.
Signed-off-by: Maurice van Veen [email protected]