Global JetStream API request queue limiting #5900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neilalexander
force-pushed
the
neil/jsrate210
branch
from
ee3cedb to
f010813
Compare
neilalexander
force-pushed
the
neil/jsrate210
branch
5 times, most recently
from
438dbc2 to
f2ee47d
Compare
neilalexander
force-pushed
the
neil/jsrate210
branch
3 times, most recently
from
8d16b37 to
bd2e80e
Compare
derekcollison
requested changes
Sep 19, 2024
Signed-off-by: Neil Twigg <[email protected]>
neilalexander
force-pushed
the
neil/jsrate210
branch
from
bd2e80e to
1b7997d
Compare
derekcollison
requested changes
Sep 19, 2024
| pending, _ := s.jsAPIRoutedReqs.push(&jsAPIRoutedReq{jsub, sub, acc, subject, reply, copyBytes(rmsg), c.pa}) | ||
| if pending >= warnThresh { | ||
| s.rateLimitFormatWarnf("JetStream request queue has high pending count: %d", pending) | ||
| limit := atomic.LoadInt64(&js.queueLimit) |
There was a problem hiding this comment.
One trick here we could do is that we know hard limit is greater them warn limit, so only if we hit warn limit do we look up limit with atomic and check hard limit.
There was a problem hiding this comment.
We can do as a followup once we figure out test approach.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should provide some protection against the server being completely overwhelmed by a build-up of JS API requests.
Signed-off-by: Neil Twigg [email protected]