Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove check for '\r\n' when processing pub args #585

Merged
merged 1 commit into from
Oct 17, 2017

Conversation

wallyqs
Copy link
Member

@wallyqs wallyqs commented Sep 11, 2017

The parser has already dropped CRLF by when processPub is called, so we can skip doing these checks there. This change also refactors the pub arg tests to use t.Run closure along with more checks for when parsing reply inboxes.

  • Link to issue, e.g. Resolves #NNN
  • Documentation added (if applicable)
  • Tests added
  • Branch rebased on top of current master (git pull --rebase origin master)
  • Changes squashed to a single commit (described here)
  • Build is green in Travis CI
  • You have certified that the contribution is your original work and that you license the work to the project under the MIT license

/cc @nats-io/core

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.06%) to 91.938% when pulling 5e58e07 on wallyqs:process-pub-args-crlf into c3e0951 on nats-io:master.

The parser has already dropped CRLF by when `processPub`
is called, so can skip doing the these checks there.
@wallyqs wallyqs force-pushed the process-pub-args-crlf branch from 5e58e07 to c8f151e Compare September 11, 2017 21:22
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 91.875% when pulling c8f151e on wallyqs:process-pub-args-crlf into c3e0951 on nats-io:master.

Copy link
Contributor

@petemiron petemiron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@petemiron petemiron requested a review from kozlovic September 20, 2017 18:59
@kozlovic kozlovic merged commit c19527c into nats-io:master Oct 17, 2017
@wallyqs wallyqs deleted the process-pub-args-crlf branch October 17, 2017 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants