[FIXED] JetStream: data race between consumer and stream when updated #5820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some tests were showing often a race between updateWithAdvisory() and isFiltered(). There may be other data races in other files that read the mset's configuration without proper locking, but this PR addresses specifically issues between consumer (consumer.go) and stream. Signed-off-by: Ivan Kozlovic <[email protected]>
kozlovic
commented
Aug 23, 2024
There was a problem hiding this comment.
@derekcollison I think I don't even need to call to mset.getCfg() since we are protected by the stream's lock there. If you agree, I will update the PR tomorrow.
Signed-off-by: Ivan Kozlovic <[email protected]>
|
I will merge after all green. |
|
@derekcollison I got a data race on a test for completely different thing (non JS). Can I add it here or do you prefer new PR for that? |
Signed-off-by: Ivan Kozlovic <[email protected]>
|
Sorry, I did not wait for your answer. It was a quick fix, so added to this PR. |
|
@derekcollison Ok, got all green, ready to merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests were showing often a race between updateWithAdvisory() and isFiltered().
There may be other data races in other files that read the mset's configuration without proper locking, but this PR addresses specifically issues between consumer (consumer.go) and stream.
Signed-off-by: Ivan Kozlovic [email protected]