[FIXED] Windows Docker Images #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylertreat
approved these changes
Jul 17, 2017
| WORKDIR /go/src/github.com/nats-io/gnatsd | ||
|
|
||
| RUN CGO_ENABLED=0 GOOS=windows GOARCH=amd64 go build -ldflags "-s -w" -o gnatsd.exe . | ||
|
|
There was a problem hiding this comment.
Why don't we set NATS_WIN_CONTAINER in this?
There was a problem hiding this comment.
Also, should this environment variable be documented somewhere?
There was a problem hiding this comment.
This Dockerfile is just used to build the executable. The executable will be extracted from nats-docker/update.sh and copied in respective nats-docker/windows sub-directories. This repo has not yet been updated.
There was a problem hiding this comment.
Check: nats-io/nats-docker#8
The use of the `svc` API prevented the NATS Server to run as a container on both nanoserver and windowsservercore Docker images. An attempt was made to replace svc.Debug with normal server.Start() if detected to be interactive, however, that did not work. The fact of detecting if interactive or not already requires connecting to the service controller apparently. This change looks up for an environment variable (NATS_DOCKERIZED) and if set to "1", will not make use of the `svc` package. This environment variable will be set in the Docker image (in nats-docker/windows/nanoserver/Dockerfile and windowsservercore/Dockerfile). Resolves #543
2 tasks
sunjayBhatia
added a commit
to cloudfoundry/diego-release
that referenced
this pull request
Nov 12, 2019
It is failing to instantiate itself as a Windows service See: - nats-io/nats-docker#9 - nats-io/nats-server#544 [#169546670] Co-authored-by: Sunjay Bhatia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of the
svcAPI prevented the NATS Server to run asa container on both nanoserver and windowsservercore Docker images.
An attempt was made to replace svc.Debug with normal server.Start()
if detected to be interactive, however, that did not work. The
fact of detecting if interactive or not already requires connecting
to the service controller apparently.
This change looks up for an environment variable (NATS_DOCKERIZED)
and if set to "1", will not make use of the
svcpackage.This environment variable will be set in the Docker image (in
nats-docker/windows/nanoserver/Dockerfile and windowsservercore/Dockerfile).
Resolves #543