Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIXED] Check for negative Offset and/or Limit when processing Connz #492

Merged
merged 1 commit into from
May 18, 2017
Merged

[FIXED] Check for negative Offset and/or Limit when processing Connz #492

merged 1 commit into from
May 18, 2017

Conversation

kozlovic
Copy link
Member

@kozlovic kozlovic commented May 17, 2017 •
edited
Loading

  • Link to issue
  • Documentation added (if applicable)
  • Tests added
  • Branch rebased on top of current master (git pull --rebase origin master)
  • Changes squashed to a single commit (described here)
  • Build is green in Travis CI
  • You have certified that the contribution is your original work and that you license the work to the project under the MIT license

Resolves #491

Changes proposed in this pull request:

Ensure that if the offset is negative, it is set to 0. If the limit
is negative, it is set to the default value.

/cc @nats-io/core

@kozlovic
[FIXED] Check for negative Offset and/or Limit when processing Connz
a87050c 
Ensure that if the offset is negative, it is set to 0. If the limit
is negative, it is set to the default value.

Resolves #491
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 90.944% when pulling a87050c on fix_negative_offset_limit_panic into 01d2f1d on master.

@tylertreat
Copy link
Contributor

lgtm

petemiron
petemiron approved these changes May 17, 2017
View reviewed changes
Copy link
Contributor

@petemiron petemiron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kozlovic kozlovic merged commit 4cef2dd into master May 18, 2017
@kozlovic kozlovic deleted the fix_negative_offset_limit_panic branch May 18, 2017 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petemiron petemiron petemiron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kozlovic @coveralls @tylertreat @petemiron