[ADDED] Configure number of connect retries for implicit routes #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…outes When a server is told to connect to a server (with auto-discovery), it tries to connect once. There have been a report where that connection fails, but would probably succeed if tried again (#408). This new parameter allows to configure the number of times a failed implicit connect should be tried. Resolves #408
| @@ -50,6 +50,7 @@ Cluster Options: | |||
| --routes <rurl-1, rurl-2> Routes to solicit and connect | |||
| --cluster <cluster-url> Cluster URL for solicited routes | |||
| --no_advertise <bool> Advertise known cluster IPs to clients | |||
| --conn_retries <number> For implicit routes, number of connect retries | |||
There was a problem hiding this comment.
would call it connect_retries
| @@ -647,6 +650,9 @@ func MergeOptions(fileOpts, flagOpts *Options) *Options { | |||
| if flagOpts.Cluster.NoAdvertise { | |||
| opts.Cluster.NoAdvertise = true | |||
| } | |||
| if flagOpts.Cluster.ConnRetries != 0 { | |||
| opts.Cluster.ConnRetries = flagOpts.Cluster.ConnRetries | |||
There was a problem hiding this comment.
Same here. ConnectRetries
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a server is told to connect to a server (with auto-discovery),
it tries to connect once. There have been a report where that
connection fails, but would probably succeed if tried again (#408).
This new parameter allows to configure the number of times a failed
implicit connect should be tried.
Resolves #408