Differentiate signal handling for windows #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windows has limited support for signals, and does not define syscall.SIGUSR1. Log rotation will be handled differently in windows. * Add signal.go for all non-windows builds * Add signal_windows.go for windows builds. Today, windows looks to be the only platform that does not have syscall.SIGUSR1 defined.
derekcollison
requested changes
Nov 22, 2016
| } | ||
| c := make(chan os.Signal, 1) | ||
|
|
||
| signal.Notify(c, syscall.SIGINT) |
There was a problem hiding this comment.
We could revert back to os.Interrupt here.
| go func() { | ||
| for sig := range c { | ||
| Debugf("Trapped %q signal", sig) | ||
| switch sig { |
There was a problem hiding this comment.
Only one sig, so no need to switch etc,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows has limited support for signals, and does not define
syscall.SIGUSR1. Log rotation will be handled differently in windows.Today, windows looks to be the only platform that does not have
syscall.SIGUSR1defined.Resolves #381