Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIXED] Client certificate verification when verify is true. #337

Merged
merged 1 commit into from
Aug 25, 2016
Merged

[FIXED] Client certificate verification when verify is true. #337

merged 1 commit into from
Aug 25, 2016

Conversation

kozlovic
Copy link
Member

When verify was set to true in the configuration, the
server was requiring a client certificate, but unfortunately
not verifying it.

Resolves #336

@kozlovic
[FIXED] Client certificate verification when verify is true.
8f7f6e9 
Server was incorrectly requiring a client certificate, but not
verifying it.

Resolves #336
@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) to 90.376% when pulling 8f7f6e9 on fix_tls_verify into c7e699a on master.

@derekcollison derekcollison merged commit e41d360 into master Aug 25, 2016
@derekcollison derekcollison deleted the fix_tls_verify branch August 25, 2016 22:44
kozlovic added a commit to nats-io/nats.c that referenced this pull request Sep 10, 2016
@kozlovic
Update test config file for TLS verify cases [ci skip]
657d915 
This will be required when server release includes
nats-io/nats-server#337. At this time the
latest server release v0.9.4 does not have the fix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kozlovic @coveralls @derekcollison