expose the nonce to custom authentication #2699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a companion to #2696 that ensure custom auth methods can actually get the nonce, I assumed it was on ClientOpts but not. |
kozlovic
approved these changes
Nov 18, 2021
ripienaar
force-pushed
the
client_auth_nonce
branch
from
8e790c2 to
59ad6f2
Compare
OK, added a bit to that test |
kozlovic
requested changes
Nov 18, 2021
server/server_test.go
Outdated
| @@ -629,6 +638,14 @@ func TestCustomClientAuthentication(t *testing.T) { | |||
| if _, err := nats.Connect(addr, nats.UserInfo("invalid", "")); err == nil { | |||
| t.Fatal("Expected client to fail to connect") | |||
| } | |||
|
|
|||
| s.opts.AlwaysEnableNonce = true | |||
There was a problem hiding this comment.
I am getting races when running your test, so need to revisit that.
There was a problem hiding this comment.
OK, I was less lazy now, think it probably fixed now
ripienaar
force-pushed
the
client_auth_nonce
branch
from
59ad6f2 to
782fd2b
Compare
Signed-off-by: R.I.Pienaar <[email protected]>
ripienaar
force-pushed
the
client_auth_nonce
branch
from
782fd2b to
ffee747
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: R.I.Pienaar [email protected]
/cc @nats-io/core