Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to check if no message exists as a test to store the message. #2506

Merged
merged 2 commits into from
Sep 9, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 49 additions & 0 deletions server/jetstream_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -12973,6 +12973,55 @@ func TestJetStreamPerSubjectPending(t *testing.T) {
}
}

func TestJetStreamPublishExpectNoMsg(t *testing.T) {
s := RunBasicJetStreamServer()
defer s.Shutdown()

config := s.JetStreamConfig()
if config != nil {
defer removeDir(t, config.StoreDir)
}

nc, js := jsClientConnect(t, s)
defer nc.Close()

_, err := js.AddStream(&nats.StreamConfig{
Name: "KV",
Subjects: []string{"KV.>"},
MaxMsgsPerSubject: 5,
})
if err != nil {
t.Fatalf("add stream failed: %s", err)
}

if _, err = js.Publish("KV.22", []byte("hello world")); err != nil {
t.Fatalf("Unexpected error: %v", err)
}

// This should succeed.
m := nats.NewMsg("KV.33")
m.Header.Set(JSExpectedLastSubjSeq, "0")
if _, err := js.PublishMsg(m); err != nil {
t.Fatalf("Unexpected error: %v", err)
}

// This should fail.
m = nats.NewMsg("KV.22")
m.Header.Set(JSExpectedLastSubjSeq, "0")
if _, err := js.PublishMsg(m); err == nil {
t.Fatalf("Expected error: %v", err)
}

if err := js.PurgeStream("KV"); err != nil {
t.Fatalf("Unexpected purge error: %v", err)
}

// This should succeed now.
if _, err := js.PublishMsg(m); err != nil {
t.Fatalf("Unexpected error: %v", err)
}
}

///////////////////////////////////////////////////////////////////////////
// Simple JetStream Benchmarks
///////////////////////////////////////////////////////////////////////////
Expand Down
26 changes: 15 additions & 11 deletions server/mqtt.go
Original file line number Diff line number Diff line change
Expand Up @@ -2139,17 +2139,21 @@ func (sess *mqttSession) save() error {
seq := sess.seq
sess.mu.Unlock()

bb := bytes.Buffer{}
bb.WriteString(hdrLine)
bb.WriteString(JSExpectedLastSubjSeq)
bb.WriteString(":")
bb.WriteString(strconv.FormatInt(int64(seq), 10))
bb.WriteString(CR_LF)
bb.WriteString(CR_LF)
hdr := bb.Len()
bb.Write(b)

resp, err := sess.jsa.storeMsgWithKind(mqttJSASessPersist, subject, hdr, bb.Bytes())
var hdr int
if seq != 0 {
bb := bytes.Buffer{}
bb.WriteString(hdrLine)
bb.WriteString(JSExpectedLastSubjSeq)
bb.WriteString(":")
bb.WriteString(strconv.FormatInt(int64(seq), 10))
bb.WriteString(CR_LF)
bb.WriteString(CR_LF)
hdr = bb.Len()
bb.Write(b)
b = bb.Bytes()
}

resp, err := sess.jsa.storeMsgWithKind(mqttJSASessPersist, subject, hdr, b)
if err != nil {
return err
}
Expand Down
12 changes: 8 additions & 4 deletions server/stream.go
Original file line number Diff line number Diff line change
Expand Up @@ -2465,12 +2465,12 @@ func getExpectedLastSeq(hdr []byte) uint64 {
}

// Fast lookup of expected stream sequence per subject.
func getExpectedLastSeqPerSubject(hdr []byte) uint64 {
func getExpectedLastSeqPerSubject(hdr []byte) (uint64, bool) {
bseq := getHeader(JSExpectedLastSubjSeq, hdr)
if len(bseq) == 0 {
return 0
return 0, false
}
return uint64(parseInt64(bseq))
return uint64(parseInt64(bseq)), true
}

// Lock should be held.
Expand Down Expand Up @@ -2686,9 +2686,13 @@ func (mset *stream) processJetStreamMsg(subject, reply string, hdr, msg []byte,
return fmt.Errorf("last msgid mismatch: %q vs %q", lmsgId, last)
}
// Expected last sequence per subject.
if seq := getExpectedLastSeqPerSubject(hdr); seq > 0 {
if seq, exists := getExpectedLastSeqPerSubject(hdr); exists {
// TODO(dlc) - We could make a new store func that does this all in one.
_, lseq, _, _, _, err := mset.store.LoadLastMsg(subject)
// If seq passed in is zero that signals we expect no msg to be present.
if err == ErrStoreMsgNotFound && seq == 0 {
lseq, err = 0, nil
}
if err != nil || lseq != seq {
mset.clfs++
mset.mu.Unlock()
Expand Down