-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Leaf Node Credentials File regex dies on CRLF file endings #6167
Labels
defect
Suspected defect such as a bug or regression
Comments
@Madgvox thank you for the report and the tracking. |
aricart
added a commit
that referenced
this issue
Nov 25, 2024
…andle CRLFs correctly. Fix #6167 Signed-off-by: Alberto Ricart <[email protected]>
neilalexander
pushed a commit
that referenced
this issue
Nov 26, 2024
…andle CRLFs correctly (#6175) Leaf node credential parsing was using a regular expression that didn't handle CRLFs correctly Fix #6167 Signed-off-by: Your Name <[email protected]> --------- Signed-off-by: Alberto Ricart <[email protected]>
neilalexander
pushed a commit
that referenced
this issue
Nov 26, 2024
…andle CRLFs correctly (#6175) Leaf node credential parsing was using a regular expression that didn't handle CRLFs correctly Fix #6167 Signed-off-by: Your Name <[email protected]> --------- Signed-off-by: Alberto Ricart <[email protected]>
neilalexander
pushed a commit
that referenced
this issue
Nov 26, 2024
…andle CRLFs correctly (#6175) Leaf node credential parsing was using a regular expression that didn't handle CRLFs correctly Fix #6167 Signed-off-by: Your Name <[email protected]> --------- Signed-off-by: Alberto Ricart <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Observed behavior
When attempting to read a .creds file with CRLF line endings via a leaf node config,
nats-server
dies with aLeafNode Remote Credentials file "..." malformed
error.Looks like this was an issue in another area of the code years ago (https://github.com/nats-io/jwt/pull/72/files), but this one is due to a different regex that doesn't have that fix:
nats-server/server/leafnode.go
Line 799 in 1a4fec8
Expected behavior
The
nats-server
executable should be able to parse CRLF line endings.Server and client version
nats-server: v2.10.22
Host environment
Windows 11
Steps to reproduce
leaf.conf
file. Mine looked like this:LeafNode Remote Credentials file "..." malformed
The text was updated successfully, but these errors were encountered: