Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to [email protected] #224

Closed
wants to merge 1 commit into from

Conversation

papandreou
Copy link

Thus upgrading to Phantom.JS 2.1.1

@nathanboktae, I saw your comment on #175, and I agree that bring-your-own-binary would be even better in the long run.

@nathanboktae
Copy link
Owner

I think all the failed tests speak loud enough but

I agree that bring-your-own-binary would be even better in the long run.

I'm very sold on this. Between the drama from Medium's phantomjs to the phantomjs to now this phantomjs-prebuilt, #167 (#199), along with code bases that aren't ready to go to phantomjs2 and I am about to support SlimerJS on mocha-phantomjs-core, I had not yet made an official announcement, but I will be deprecating this project in favor of the BYOB version - after I move the command line parsing stuff into the core. There's too much hurt in trying to force users on the same binary, and force them in a certain way to get a binary. Most Hosted CI ssytems have it pre-instanalled, if not adding a wget | tar command is really trivial.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants