Skip to content

Commit

Permalink
fix(build)!: update to zig 0.14.0 (#136)
Browse files Browse the repository at this point in the history
* fix(build)!: update to zig 0.14.0

BREAKING: this PR changes the package name from `ziglua` to
`lua_wrapper`. not using `zig` in the package name has been
repeatedly communicated as best practices, analogous to `npm`'s naming
guidelines. for this particular package, this is complicated by the
fact that `ziglua` provides far more than just `lua` packaged for
Zig's build system (which already exists in numerous places), but also
aims to provide ergonomic and powerful Zig abstractions on top of the
Lua C implementation. For this reason, I chose to add "bindings" to
the name.

NB - the "fingerprint" field in build.zig.zon is new in Zig 0.14.0 and
is computed in part based on the name. once we have settled on the
name, if it is not "lua_wrapper" it will be necessary to delete the
fingerprint line and regenerated it.

* fix(ci): update build runners to zig 0.14.0

* package: lua_bindings -> lua_wrapper
  • Loading branch information
robbielyman authored Mar 6, 2025
1 parent 00a3c39 commit 1a18506
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
uses: actions/configure-pages@v5
- uses: mlugg/setup-zig@v1
with:
version: 0.14.0-dev.3259+0779e847f
version: 0.14.0
- run: make docs
- name: Upload artifact
uses: actions/upload-pages-artifact@v3
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
- name: Setup Zig
uses: mlugg/setup-zig@v1
with:
version: 0.14.0-dev.3259+0779e847f
version: 0.14.0

- name: Run tests
run: make test
3 changes: 2 additions & 1 deletion build.zig.zon
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
.{
.name = "ziglua",
.name = .lua_wrapper,
.fingerprint = 0xb40fd4eedb02233b, // changing this has security and trust implications
.version = "0.1.0",
.paths = .{ "build.zig", "build.zig.zon", "src", "license", "include", "build" },

Expand Down

0 comments on commit 1a18506

Please sign in to comment.