-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
auto merge main into release/* #1775
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Emily Soth <[email protected]>
Co-authored-by: Emily Soth <[email protected]>
Co-authored-by: Emily Soth <[email protected]>
…1580-automate-codesigning-in-release Conflicts: HISTORY.rst
Co-authored-by: Doug <[email protected]>
….com:phargogh/invest into feature/1580-automate-codesigning-in-release
Signature files are now pushed to the bucket alongside the .exe file, and we check whether the file exists before enqueueing the exe. RE:#1580
…ing-in-release Automate Code Signing of Windows Binary
Merge conflict on history, doing a separate PR as instructed by the instructions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge main into release/3.15.0
This PR was automatically generated in response to a push to
main
,and is a chance to review any changes that will be included in the release
branch before merging. Under most circumstances, this PR will probably be
a formality. However, there are a few cases where we may need to do some
extra work to make sure
release/3.15.0
contains what it should after themerge:
There is a merge conflict in this PR
git pull
the upstreammain
andrelease/3.15.0
.pr-resolution
branch off ofrelease/3.15.0
:pr-resolution
.pr-resolution
intorelease/3.15.0
, and include a linkto the origin PR in the description.
pr-resolution
branch. That willhelp us avoid confusion and extra work down the road when we do this again.
This PR contains content that should not be in
release/3.15.0
and close the PR.
git pull
the upstreammain
andrelease/3.15.0
.pr-resolution
branch off ofrelease/3.15.0
:release/3.15.0
however itneeds to be handled.
pr-resolution
.pr-resolution
intorelease/3.15.0
, and include a linkto the origin PR in the description.
pr-resolution
branch. That willhelp us avoid confusion and extra work down the road when we do this again.
What happens if we accidentally merge something we shouldn't?
There are several possibilities for recovery if we get to such a state.
directly after the PR is merged.
release/3.15.0
, back out of the changes or edit files needed to resolvethe issue, and PR the branch back into
release/3.15.0
.Why was this PR created?
The workflow defining this PR is located at
.github/workflows/auto-pr-from-main-into-releases.yml
. In short, this PRwas created because there was a push to
main
that triggered thisworkflow. Some events that can trigger this include:
main
main
main
, if ever that happens (which shouldn't be thecase given our branch protections)