Ignore compiled InVEST models. #1765
Merged
+329
−296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… branch, plugins use pip to install said feature branch. For Windows machines this means we expect a C++ compiler, which isn't always guaranteed. For the release of plugins, this won't be an issue because we'll point to a conda forge feedstock with everything pre-built.
emlys
requested changes
Feb 4, 2025
There was a problem hiding this comment.
Thanks @dcdenu4! I do think it would be helpful to skip the tests so we're not seeing a bunch of failures, that should be possible by adding to the top of each test module:
pytestmark = pytest.mark.skip()
https://docs.pytest.org/en/latest/how-to/skipping.html#skip-all-test-functions-of-a-class-or-module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For development of the plugins feature branch, plugins use pip to install said feature branch. For Windows machines this means we expect a C++ compiler, which isn't always guaranteed. For the release of plugins, this won't be an issue because we'll point to a conda forge feedstock with everything pre-built.
Obviously, this will break testing. Happy to try and skip testing the compiled models. An alternative to making this change in the feature branch is to create another branch from
feature/pluginsand make this change there. And then have plugins point to that branch instead of this one. Curious what you think @emlys .Created issue #1766 to remind us to revert this for the release.