Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Python 3.8; add Python 3.13 #1756

Merged
merged 3 commits into from
Jan 30, 2025
Merged

Drop Python 3.8; add Python 3.13 #1756

merged 3 commits into from
Jan 30, 2025

Conversation

davemfish
Copy link
Contributor

@davemfish davemfish commented Jan 29, 2025 •
edited
Loading

One test case failed under Python 3.13; seemingly a breaking change in csv acceptable delimiters.

Fixes #1755

Checklist

  • Updated HISTORY.rst and link to any relevant issue (if these changes are user-facing)
  • Updated the user's guide (if needed)
  • Tested the Workbench UI (if relevant)

@davemfish davemfish marked this pull request as ready for review January 29, 2025 21:29
@davemfish davemfish requested a review from dcdenu4 January 29, 2025 21:30
dcdenu4
dcdenu4 approved these changes Jan 30, 2025
View reviewed changes
Copy link
Member

@dcdenu4 dcdenu4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me, thanks @davemfish

@dcdenu4 dcdenu4 merged commit 53f5572 into natcap:main Jan 30, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcdenu4 dcdenu4 dcdenu4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GHA: remove Python 3.8 & add Python 3.13
2 participants
@davemfish @dcdenu4