Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with over- and under-supply values missing from UNA administrative vector #1513

Merged

Conversation

phargogh
Copy link
Member

This PR addresses an issue with the sample data when running UNA with search radii defined per population group. The fields Pund_adm and Povr_adm, per the User's guide, are supposed to be the sum of over- and under-supplied populations across all population groups, but these values just weren't being summed in the output vector. This has been corrected and test values updated.

Fixes #1512

Checklist

  • Updated HISTORY.rst and link to any relevant issue (if these changes are user-facing)
  • Updated the user's guide (if needed)
  • Tested the Workbench UI (if relevant)

Copy link
Member

@dcdenu4 dcdenu4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fairly straightforward to me, thanks @phargogh !

@dcdenu4 dcdenu4 merged commit 581cfb2 into natcap:main Jan 26, 2024
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UNA: Pund_adm and Povr_adm are both 0 when radii defined by population group
2 participants