Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests for pandas 2.2.0 #1507

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Update tests for pandas 2.2.0 #1507

merged 1 commit into from
Jan 23, 2024

Conversation

emlys
Copy link
Member

@emlys emlys commented Jan 22, 2024

Description

Fixes #1506
New in pandas 2.2.0, assert_frame_equal defaults to exact comparison when testing against integers. The expected values are floats so we need to allow for the usual amount of float tolerance. https://pandas.pydata.org/docs/whatsnew/v2.2.0.html#other-api-changes

Checklist

  • Updated HISTORY.rst and link to any relevant issue (if these changes are user-facing)
  • Updated the user's guide (if needed)
  • Tested the Workbench UI (if relevant)

@emlys emlys marked this pull request as ready for review January 22, 2024 20:58
@emlys emlys requested a review from dcdenu4 January 22, 2024 20:58
@emlys emlys self-assigned this Jan 22, 2024
Copy link
Member

@dcdenu4 dcdenu4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohoo, pandas 2.2.0!

@dcdenu4
Copy link
Member

dcdenu4 commented Jan 23, 2024

MacOS binary test failure looks unrelated.

@dcdenu4 dcdenu4 merged commit f02c36a into natcap:main Jan 23, 2024
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crop Production tests broken on main
2 participants