Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GHA failures due to node version conflicts #1465

Closed
davemfish opened this issue Dec 11, 2023 · 0 comments · Fixed by #1471
Closed

GHA failures due to node version conflicts #1465

davemfish opened this issue Dec 11, 2023 · 0 comments · Fixed by #1471
Assignees
@davemfish
Labels
critical for issues likely to obstruct the whole dev team (e.g. broken builds) in progress This issue is actively being worked on
Milestone
3.14.1

Comments

@davemfish
Copy link
Contributor

This has been coming up on Windows:

error [email protected]: The engine "node" is incompatible with this module. Expected version "^14 || ^16 || ^17 || ^18 || ^19". Got "20.10.0"
@davemfish davemfish added the critical for issues likely to obstruct the whole dev team (e.g. broken builds) label Dec 11, 2023
@davemfish davemfish self-assigned this Dec 11, 2023
@davemfish davemfish added this to the 3.14.1 milestone Dec 11, 2023
davemfish added a commit to davemfish/invest that referenced this issue Dec 11, 2023
@davemfish
updated to electron v28. natcap#1465
15bcded
davemfish added a commit to davemfish/invest that referenced this issue Dec 11, 2023
@davemfish
upgraded electron-builder and pptr. natcap#1465
16ab643
davemfish added a commit to davemfish/invest that referenced this issue Dec 11, 2023
@davemfish
upgraded babel & eslint. natcap#1465
dc3cedd
davemfish added a commit to davemfish/invest that referenced this issue Dec 11, 2023
@davemfish
upgraded testing-library and misc others. natcap#1465
dfd1bd3
davemfish added a commit to davemfish/invest that referenced this issue Dec 11, 2023
@davemfish
add back the yarn lockfile. natcap#1465
5b82ebe
davemfish added a commit to davemfish/invest that referenced this issue Dec 11, 2023
@davemfish
stick no node version 18 for now. natcap#1465
9dc714e
@davemfish davemfish mentioned this issue Dec 11, 2023
Merged
3 tasks
davemfish added a commit to davemfish/invest that referenced this issue Dec 11, 2023
@davemfish
one more place where node version is defined. natcap#1465
7705c79
@davemfish davemfish added the in progress This issue is actively being worked on label Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davemfish davemfish

Labels
critical for issues likely to obstruct the whole dev team (e.g. broken builds) in progress This issue is actively being worked on
Projects
None yet
Milestone
3.14.1
Development

Successfully merging a pull request may close this issue.

stick to node version 18 in build environments davemfish/invest
1 participant
@davemfish