Allow use of the original working directory for tasks #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nat-n
requested changes
Aug 5, 2023
There was a problem hiding this comment.
Hi @Spiffyk, thanks for the PR, I think this feature is a good idea!
I left some comments about things that need to be improved before this can be merged. We also need to cover this feature with a test, and the CI is failing on coding standards (poe format should fix it).
If you're keen to own this then great (and please let me know), otherwise I should have some time soon to fix it up before merging.
|
Hi, @nat-n, I'll be happy to own this and fix it up. Thanks for the review, I'll look into all of it soon! |
For some tasks, it may be useful to use the working directory from which the task has been executed, since they may be meant to operate on some files that the user points them to. This commit introduces a special '$exec_cwd' value for the 'cwd' task option, which does exactly that. Existing use-cases are unaffected by this addition and work as usual.
Co-authored-by: Nat Noordanus <[email protected]>
nat-n
requested changes
Aug 11, 2023
Co-authored-by: Nat Noordanus <[email protected]>
nat-n
requested changes
Aug 12, 2023
Co-authored-by: Nat Noordanus <[email protected]>
Remove extra lines
|
Thanks for the help to get this in properly! 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some tasks, it may be useful to use the working directory from which the task has been executed, since they may be meant to operate on some files that the user points them to. This commit introduces a special '$exec_cwd' value for the 'cwd' task option, which does exactly that. Existing use-cases are unaffected by this addition and work as usual.