-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't in-lined tasks from another file with cwd #158
Comments
Added PR: #159 |
Hi @rjaduthie, thanks for the issue! I'm out of the office the next week, but I'll look at this when I get back :) |
[like] Roger Duthie reacted to your message:
…________________________________
From: Nat Noordanus ***@***.***>
Sent: Wednesday, July 26, 2023 7:09:31 PM
To: nat-n/poethepoet ***@***.***>
Cc: Roger Duthie ***@***.***>; Author ***@***.***>
Subject: Re: [nat-n/poethepoet] Can't in-lined tasks from another file with cwd (Issue #158)
Hi @rjaduthie<https://github.com/rjaduthie>, thanks for the issue! I'm out of the office the next week, but I'll look at this when I get back :)
—
Reply to this email directly, view it on GitHub<#158 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BBFLMSUVNT6DOUWER3572QTXSFTOXANCNFSM6AAAAAA2YXHYIE>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
nat-n
added a commit
to rjaduthie/poethepoet
that referenced
this issue
Aug 5, 2023
nat-n
added a commit
to rjaduthie/poethepoet
that referenced
this issue
Aug 5, 2023
nat-n
added a commit
that referenced
this issue
Aug 5, 2023
Fixes #158 Poe no longer crashes if a included task file is configured with `cwd` and includes string task declarations. Included task files may now include the following global options which will be respected for associated tasks: - default_task_type - default_array_task_type - default_array_item_task_type --------- Co-authored-by: Nat Noordanus <[email protected]>
#159 is merged, this will be fixed in the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
If trying to use the syntax documented here:
... there is an exception if any tasks are defined "in-line" like:
The issue is that these tasks are loaded as strings so that on line 291
config.py
thetask_def
is a string and on line 305 there is a type error whentask_def["cwd"]
is attempted.Possible solution
To convert any string tasks to objects like:
I can create a PR at some point if you think this is:
The text was updated successfully, but these errors were encountered: