Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protect TrickOps progres bar from divide by zero #1664

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

ddj116
Copy link
Contributor

@ddj116 ddj116 commented Mar 7, 2024

Closes #1663

@ddj116
Copy link
Contributor Author

ddj116 commented Mar 7, 2024

@hchen99 per your request here's the MR with only this change. Since TrickOps is now a critical part of our workflow, both this and #1662 will be needed for EG to move forward with Trick on Rocky 8 Linux, which is coming to our lab likely in early April.

@coveralls
Copy link

Coverage Status

coverage: 55.911% (+0.002%) from 55.909%
when pulling 9d960cc on 1663-trickops-protect-div-zero
into 2ac342c on master.

@hchen99
Copy link
Contributor

hchen99 commented Mar 7, 2024

Thanks for the PR. It looks very straightforward. Will try to merge both of your PRs if not this week probably early next week.

@sharmeye sharmeye merged commit e184db0 into master Mar 8, 2024
11 checks passed
@hchen99 hchen99 deleted the 1663-trickops-protect-div-zero branch April 10, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TrickOps: Protect for divide by zero in progress bar computation
4 participants