Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardized error messaging in Sim Control Panel. #1636

Merged

Conversation

Mrockwell2
Copy link
Contributor

No description provided.

@Mrockwell2 Mrockwell2 linked an issue Jan 9, 2024 that may be closed by this pull request
@coveralls
Copy link

coveralls commented Jan 9, 2024

Coverage Status

coverage: 55.859% (+0.005%) from 55.854%
when pulling 8c4edf3 on 1631-inconsistent-error-message-output-in-sim-control-panel
into 65c20d9 on master.

@hchen99
Copy link
Contributor

hchen99 commented Jan 10, 2024

Thanks Marcus! Thought this is for a larger scope initially. After looking further, realized the effort is for printing the error only to the status msg pane of the sim control panel when the connection to a variable server can't be established unless the sim control panel is in Lite mode, then use a popup window for the error msg. I am good with the idea.

  • Original:

    • Run trick-simcontrol without specifying host and port, the error msg goes to a popup window regardless of the GUI mode (either Full or Lite)
    • Run trick-simcontrol host port with specified host and port, the error msg goes to screen if the host is not right or the port is not right for connection.
  • New:

    • Run trick-simcontrol without specifying host and port
      • Lite: the error msg goes to a popup window
      • Full: the error msg goes to the status msg pane
    • Run trick-simcontrol host port with specified host and port, the error msg is intended to go to the status msg pane if the host is not right or the port is not right for connection.
      • Marcus, might be just me, would you please check this as I am getting NullPointerException because the status msg pane is not ready yet for displaying error msg when the sim control panel is launched this way? Thanks!
        • Basically print error on screen if status msg pane is not ready otherwise print to status msg pane or a popup window

@hchen99
Copy link
Contributor

hchen99 commented Jan 11, 2024

All looks good to me.

@sharmeye sharmeye merged commit dad8e3b into master Jan 18, 2024
11 checks passed
@sharmeye sharmeye deleted the 1631-inconsistent-error-message-output-in-sim-control-panel branch January 14, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent Error Message Output in Sim Control Panel
4 participants