Zip SWIG-generated python modules #1145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbankieris
force-pushed
the
zip-python-modules
branch
from
74d6383 to
987211e
Compare
ddj116
reviewed
May 17, 2021
|
@ddj116 I think this is ready now. Can you give it a spin before I merge? |
|
Confirmed this MR works fine with my gateway project -- we'll move to it as soon as it's in master. Antares has to wait for other dependency reasons unrelated to these changes, so we'll continue to "roll our own zip" in that project until we are able to step up to the latest Trick. Approved and much appreciated! |
dbankieris
force-pushed
the
zip-python-modules
branch
from
e6748cf to
8246520
Compare
|
@alexlin0 Dan and I thought it might be helpful to rename |
Hide the non-zipped Python modules to indicate to users that changing them will have no effect on the sim. Refs #1144
|
No objection to the move. |
dbankieris
force-pushed
the
zip-python-modules
branch
from
8246520 to
2c06ae6
Compare
astrophysics
referenced
this pull request
in astrophysics/trick
Nov 24, 2022
Zip SWIG-generated python modules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1144