Adding phase configure to manual cookiecutter. nasa/fprime#2820 #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomas-bc
reviewed
Jul 30, 2024
| @@ -143,6 +143,8 @@ void setupTopology(const TopologyState& state) { | |||
| setBaseIds(); | |||
| // Autocoded connection wiring. Function provided by autocoder. | |||
| connectComponents(); | |||
| // Autocoded configuration. Function provided by autocoder. | |||
| configComponents(state); | |||
There was a problem hiding this comment.
@LeStarch this has been fixed in https://github.com/nasa/fprime-tools/pull/206/files already
Should the call be made before configureTopology() ? In which case it should be removed line 153 (further below)
There was a problem hiding this comment.
Yes, I believe so. The phase code cannot, by definition, know or care what the hand config does. As such, I assumed it was safest to place this first.
There was a problem hiding this comment.
@thomas-bc fixed! What was the reason to place this after register commands?
thomas-bc
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Fixes #2820.