-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EDSC-4326: Update node and replace node-sass #80
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reminding myself to update edsc-eslint-config
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #80 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 23 17 -6
Lines 719 128 -591
Branches 182 14 -168
==========================================
- Hits 719 128 -591 ☔ View full report in Codecov by Sentry. |
Using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to bump the npm version
.github/ISSUE_TEMPLATE/custom.md
Outdated
|
||
--- | ||
|
||
Please review [Contribution.md](https://github.com/nasa/earthdata-search/blob/master/CONTRIBUTING.md) before contributing to this project. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This URL is still pointing to earthdata-search
Overview
What is the feature?
Updates to a supported version of node and removes node-sass to fix installation issues related to its deprecation.
What is the Solution?
lts/jod
node-sass
in favor ofsass
What areas of the application does this impact?
While doing the change to
sass
I noticed the opportunity to fix some issues with the sass structure, example, and linting to clean up the project and improve dev UX.Testing
Reproduction steps
Check the example site locally
npm run start
Check the library works inside Earthdata Search
npm pack
in theedsc-timeline
directoryearthdata-search
earthdata-seach
Checklist