Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EDSC-4326: Update node and replace node-sass #80

Merged
merged 13 commits into from
Dec 12, 2024
Merged

EDSC-4326: Update node and replace node-sass #80

merged 13 commits into from
Dec 12, 2024

Conversation

trevorlang
Copy link
Collaborator

@trevorlang trevorlang commented Dec 9, 2024

Overview

What is the feature?

Updates to a supported version of node and removes node-sass to fix installation issues related to its deprecation.

What is the Solution?

  • Uses node version lts/jod
  • Removes node-sass in favor of sass

What areas of the application does this impact?

While doing the change to sass I noticed the opportunity to fix some issues with the sass structure, example, and linting to clean up the project and improve dev UX.

Testing

Reproduction steps

Check the example site locally

  1. Run npm run start
  2. Load the example site
  3. Confirm all demo pages work as expected

Check the library works inside Earthdata Search

  1. Run npm pack in the edsc-timeline directory
  2. Install the generated package in earthdata-search
  3. Spot check the timeline functionality
  4. Run the unit and integration tests in earthdata-seach
  5. Confirm there are no timeline related tests that fail

Checklist

  • I have added automated tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Copy link
Collaborator Author

@trevorlang trevorlang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminding myself to update edsc-eslint-config

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (fdd5794) to head (9106e80).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##              main       #80    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           23        17     -6     
  Lines          719       128   -591     
  Branches       182        14   -168     
==========================================
- Hits           719       128   -591     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eudoroolivares2016
Copy link
Contributor

Using npm pack and pulling this into EDSC and doing some regression testing I wasn't seeing any issues. I think those GH actions jobs there needs to be a config change into the settings though "the waiting for status hydrogen:) ones that is I ran into a similar issue in graphql but, don't have the permissions to update that one

.github/ISSUE_TEMPLATE/bug_report.md Outdated Show resolved Hide resolved
.github/pull_request_template.md Show resolved Hide resolved
.nvmrc Outdated Show resolved Hide resolved
cypress/e2e/focused_intervals.cy.js Outdated Show resolved Hide resolved
example/src/components/Output/Output.scss Outdated Show resolved Hide resolved
example/src/index.html Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/css/variables/_constants.scss Outdated Show resolved Hide resolved
src/css/variables/_index.scss Outdated Show resolved Hide resolved
Copy link
Contributor

@macrouch macrouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to bump the npm version


---

Please review [Contribution.md](https://github.com/nasa/earthdata-search/blob/master/CONTRIBUTING.md) before contributing to this project.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This URL is still pointing to earthdata-search

@trevorlang trevorlang merged commit 6b7f48f into main Dec 12, 2024
9 checks passed
@trevorlang trevorlang deleted the EDSC-4326 branch December 12, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants