Allow lambdaArn to be specified as an arn or a function name #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ifestus
reviewed
Oct 10, 2018
index.js
Outdated
| const err = new TypeError(`Unable to determine lambda function name from ${lambdaArn}`); | ||
| log.error(`Unable to determine lambda function name from ${lambdaArn}`, err); | ||
| } | ||
| log.sender = `cumulus-ecs-task/${getFunctionName(lambdaArn)}`; |
There was a problem hiding this comment.
Are we losing valuable functionality by no longer catching the case in which the lambdaArn actually isn't a lambdaArn? I may be mistaken, but it appears that under the proposed implementation, any parameter passed into getFunctionName that doesn't begin with arn:aws:lambda will be returned as is.
There was a problem hiding this comment.
So the issue is that the parameter is called lambdaArn, but it apparently accepts a Lambda function name as well as an ARN. We need to add the Lambda function name to the logs, though, so the two cases here are that 1) the parameter is an ARN or 2) the parameter is a simple Lambda function name already.
laurenfrederick
approved these changes
Oct 10, 2018
ifestus
approved these changes
Oct 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.