Integration Candidate 2020-05-13 #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When cleaning up a task the child task resources should be cleaned first, followed by the main task resources. This is because child tasks are also associated with the original creator within OSAL and will be found through OSAL ForEachObject, and also via links within the ES task table. By cleaning child tasks first, this avoids attempting to delete the child task twice.
Resolve remaining alignment warnings in the unit test and stub code. In es_UT.c test cases were passing a char* as a stack pointer (uint32*) Memory pool code was also using uint8[] buffer as uint32. Most casting becomes unnecessary when defined as the correct type.
Add missing UT_Stub_RegisterContext to CFE_EVS_SendEvent and CFE_ES_WriteToSysLog. This will create the correct register buffer size.
Changes Message Key from uint16 to uint32 to avoid rollover
Fix #681, Resolve doxygen warnings for tbl
Fix #309, Typo in CFE_ES_RestartApp WriteToSysLog
Fix #684, order of CleanupTaskResources
Fix #687, validate table handle prior to use
Fix #693, Utilize UT macros in sb_UT
Fix #657, Add UT_Stub_RegisterContext to CFE_EVS_SendEvent and CFE_ES_WriteToSysLog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #309
Fix #657
Fix #679
Fix #681
Fix #684
Fix #707
Testing performed
Bundle CI - https://travis-ci.com/github/nasa/cFS/builds/167639047
Expected behavior changes
PR #673 - using ut stubs CFE_EVS_SendEvent and CFE_ES_WriteToSysLog, the register buffer will have the correct size. access to register buffer element will exist
PR #685 - Both the main task and the child task(s) are successfully deleted and restarted after the exception occurs.
PR #686 - Fixes doxygen warnings for the tbl subsystem.
PR #691 - No compiler warnings or errors on cross build.
PR #699 - Fixes a typo
PR #708 - Changes Message Key from uint16 to uint32 to avoid rollover and system hang
System(s) tested on
Bundle CI - Ubuntu:Bionic
Additional context
Part of nasa/cFS#87
See PRs for detailed changes and more testing information
Contributor Info - All information REQUIRED for consideration of pull request
Jose Tovias, CACI-LZT Technology
Joseph Hickey, Vantage Systems, Inc.
Christopher D. Knight, NASA-ARC
Jacob Hageman - NASA-GSFC