-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #532, Link CFE core with OSAL BSP #533
Fix #532, Link CFE core with OSAL BSP #533
Conversation
Enables future transition to using the OSAL BSP rather than duplicating startup logic in the CFE PSP.
CCB 2020-03-25: Approved |
Please hold off on merging this one for now, it has a relationship to nasa/osal#261 and on second look it might be easier to handle it via |
I merged it into the IC but I won't merge IC into master. I see that the nasa/osal#261 doesn't have an attached PR yet. Does it make sense to delay this fix if the new solution doesn't exist yet? @skliper thoughts? |
I'd back it out of the IC branch if @jphickey doesn't think this is the way to go, or at least hold off on merge until confirmed. |
I'll bring it up at CCB |
CCB 2020-04-01 @jphickey working on alternate implementation. Remove from integration-candidate |
Rejecting nasa/cFE#533 which was merged into cFE's integration candidate
Describe the contribution
Link the CFE core target with the OSAL BSP library by including this in the final link library list.
Fixes #532
Testing performed
Build and run unit tests on native (x86-64) and PC-RTEMS. Confirm CFE runs normally, no change.
Expected behavior changes
No behavior changes. This change only enables future transition to using the OSAL BSP rather than
duplicating startup logic in the CFE PSP. Initially the linker should drop/ignore the content of this library.
System(s) tested on
Additional context
This depends on the related change in nasa/osal#261 which defines the separate
osal_bsp
target. It should be merged at the same time (or after) the OSAL change is merged.Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.