-
Notifications
You must be signed in to change notification settings - Fork 331
Depth odometry organized icp #388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rsoussan
merged 589 commits into
nasa:develop
from
rsoussan:depth_odometry_organized_icp
Jan 8, 2022
Merged
Depth odometry organized icp #388
rsoussan
merged 589 commits into
nasa:develop
from
rsoussan:depth_odometry_organized_icp
Jan 8, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, expect initial estimate as source_T_target
…_odometry_organized_icp
bcoltin
approved these changes
Jan 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure you add new packages to platform too
luisa-mao
pushed a commit
to luisa-mao/astrobee-1
that referenced
this pull request
Jul 11, 2023
Added depth odometry sweep tool, optional refinement of the image feature depth odometry estimate, and organized methods taking advantage of the grid like structure of point clouds to speed up computations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added functions to take advantage of the layout of our point cloud being "organized" (having a width and height since it's from a depth camera) to speed up normal estimation. Also added functions for sampling using normal alignments to further speed up ICP.
This branch is off of the open pr " Added Depth Odometry Sweep Tool and Optional ICP-based refinement for Image Feature Depth Odometry #381, so depending on the merge order that can be closed or merged before this one (I couldn't find an option to make the destination that pr, let me know if there's a better way to do this).
This requires new debs to be installed (libpcl-registration and libpcl-keypoints).