Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MsgId/TopicId conflict error messages not correctly shown #27

Closed
jphickey opened this issue Jan 18, 2023 · 0 comments
Closed

MsgId/TopicId conflict error messages not correctly shown #27

jphickey opened this issue Jan 18, 2023 · 0 comments
Assignees
@jphickey
Labels
bug Something isn't working

Comments

@jphickey
Copy link
Contributor

If the EDS configuration results in a conflict between MsgIds or TopicIds, the EDS tool is supposed to display an error message indicating which value is in conflict and between what components/packages.

However, due to some underlying changes, the "MsgId" variable is a table, not a simple integer. So it cannot be directly printed as is attempted to here:

EdsLib/cfecfs/missionlib/eds/75-cfe_sb_dispatch_tables.lua

Line 114 in 683791c

exist_comp.reqintf:error(string.format("MsgId Conflict on MsgId=%04x/TopicId=%d with %s",MsgId,TopicId,binding.reqintf:get_qualified_name()))

EdsLib/cfecfs/missionlib/eds/75-cfe_sb_dispatch_tables.lua

Line 120 in 683791c

exist_comp.reqintf:error(string.format("TopicId Conflict on MsgId=%04x/TopicId=%d with %s",MsgId,TopicId,binding.reqintf:get_qualified_name()))

To correct this, it needs to use the Value member of MsgId, which is the integer.
@jphickey jphickey self-assigned this Jan 18, 2023
@jphickey jphickey added the bug Something isn't working label Jan 18, 2023
jphickey added a commit to jphickey/EdsLib that referenced this issue Jan 18, 2023
@jphickey
Fix nasa#27, type mismatch in MsgId conflict error message
480c401 
Corrects a type mismatch where this needs to take the "Value" member of
the table rather than using the MsgId field directly, which is a table.
jphickey added a commit that referenced this issue Jan 18, 2023
@jphickey
Merge pull request #28 from jphickey/fix-27-id-conflict
7dac5fd 
Fix #27, type mismatch in MsgId conflict error message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jphickey