CMR-10323: Int test periodically failing

[jmaeng72]

Overview

What is the feature/fix?

Int test periodically failing

What is the Solution?

Caches needed to be refreshed and tests did not wait long enough sometimes for it to complete in the backend. Increased time to wait to give caches enough time to fully refresh

What areas of the application does this impact?

Int tests

Checklist

• I have updated/added unit and int tests that prove my fix is effective or that my feature works
• New and existing unit and int tests pass locally and remotely
• clj-kondo has been run locally and all errors corrected
• I have removed unnecessary/dead code and imports in files I have changed
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have cleaned up integration tests by doing one or more of the following:
  • migrated any are2 tests to are3 in files I have changed
  • de-duped, consolidated, removed dead int tests
  • transformed applicable int tests into unit tests
  • refactored to reduce number of system state resets by updating fixtures (use-fixtures :each (ingest/reset-fixture {})) to be :once instead of :each

[eereiter]

Oh well - an increase in testing time - here and for other tests. But this still could break if the tests are running slow? Can clear-caches be made synchronous or is there a way to tell when the cache is clear? Or are we waiting on something else? Why do we have to wait?

[jmaeng72]

the errors were coming from the kms cache not reseting and so we got a lot of validation errors. I'm sure we could create another func or update this one to make clear-cache synchronous but it is attached to a func that is clearing all the dev-system caches at once.

And yes the test could potentially fail if 3 seconds is not long enough to wait for all the caches to refresh