-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMR-10287: Create feature toggle for cmr-validate-keyword default behavior change #2202
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2202 +/- ##
===========================================
- Coverage 58.23% 29.35% -28.88%
===========================================
Files 1056 996 -60
Lines 71012 67665 -3347
Branches 2023 1157 -866
===========================================
- Hits 41351 19865 -21486
- Misses 27772 46694 +18922
+ Partials 1889 1106 -783 ☔ View full report in Codecov by Sentry. |
@@ -159,8 +159,10 @@ The following fields are validated: | |||
* [Data Format](https://gcmd.earthdata.nasa.gov/kms/concepts/concept_scheme/dataformat?format=csv) - Archival and Distribution File Format, and GetData Format | |||
* [ProcessingLevel] (https://gcmd.earthdata.nasa.gov/kms/concepts/concept_scheme/productlevelid?format=csv) - productlevelid | |||
|
|||
**Note**: cmr-validate-keywords is set to TRUE by default | |||
**Note**: if cmr-validate-keywords header is not set explicitly, it will behave as if it was set to FALSE by default behind the scenes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this line probably won't be updated again until the feature toggle is removed, I'm wondering if we need to communicate here that work is being done to change it to default true in the various environments. Perhaps a note in parens?
Though I'm not sure how important that is or how quick we'll be getting that work done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can leave it and I will make an update to this doc as soon as we toggle this feature on in PROD
…avior change (#2202) * add feature toggle * update documentation to say default is false
Overview
What is the feature/fix?
CMR-10182 changed api behavior for ingesting collections by making cmr-validate-keywords default to true instead of its previous default behavior of false.
What is the Solution?
A feature toggle on top of this behavior change so we can control when this feature become public or not in all envs
What areas of the application does this impact?
Ingest
Checklist