Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update master_parts_list_raw.csv #351

Merged
merged 2 commits into from
Jan 27, 2022
Merged

Conversation

JoshSharpe
Copy link
Contributor

@JoshSharpe JoshSharpe commented Dec 21, 2021

  • Added file location for 3D printed encoder STL file.
  • Updated T5 part to require 20, instead of 1. Section 3.9 of the PCB Assembly requires 20 for the Roboclaw standoffs but currently the parts list suggests only ordering 1.

- Added file location for 3D printed encoded STL file.
- Updated 4.5x12" plate from servo city (discontinued) to Sculpto
- Updated T5 part to require 20, instead of 1. Section 3.9 of the PCB Assembly requires 20 for the Roboclaw standoffs but currently the parts list suggests only ordering 1.
@dcschooley
Copy link
Collaborator

I'm closing this because the suggested file for laser cutting is a direct copy from ServoCity and they might not like that due to their patents.It also has extra holes which might compromise the strength and adds to the cost. I've replace the file and added some additional document in pull request #353. The change to the T5 part will need to be redone.

@dcschooley dcschooley closed this Jan 6, 2022
@JoshSharpe
Copy link
Contributor Author

Hmm, @dcschooley I didn't mention ServoCity's 4.5x12" part in the PR. I just removed ServoCity from the part all together and said it needs to be laser cut. The filename I refer to is the first bullet point. I believe we are not on the same page.

@dcschooley
Copy link
Collaborator

dcschooley commented Jan 12, 2022

Hmm, @dcschooley I didn't mention ServoCity's 4.5x12" part in the PR. I just removed ServoCity from the part all together and said it needs to be laser cut. The filename I refer to is the first bullet point. I believe we are not on the same page.

I might have misinterpreted what you said on Slack. If so, I'm sorry about that. I thought you had converted the ServoCity drawing to something that could be laser cut. That's a good start, but probably isn't great because ServoCity has the design patented. That may or may not matter. In any case, the drawing in my lacks the extra holes, which saves strength and cost. It also has larger holes to pass the motor wires into the body, and that will be needed for the revised PCB rev. I've reopened the PR for you. Please remove the stuff about the 4.5x12 plate and all should be good.

@dcschooley dcschooley reopened this Jan 12, 2022
@Achllle Achllle requested a review from dcschooley January 18, 2022 11:07
@Achllle
Copy link
Collaborator

Achllle commented Jan 18, 2022

@JoshSharpe ping on the above, we'd love to have your contribution merged so others can benefit as well! Thanks

@JoshSharpe
Copy link
Contributor Author

Removed the change @dcschooley requested. Should be good to merge if approved.

Copy link
Collaborator

@dcschooley dcschooley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@Achllle Achllle merged commit cd993e1 into nasa-jpl:master Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants